codope commented on code in PR #12420: URL: https://github.com/apache/hudi/pull/12420#discussion_r1869703235
########## website/docs/metadata_indexing.md: ########## @@ -11,27 +11,30 @@ of Hudi depends on the metadata table. Different types of index, from `files` in to `column_stats` index for data skipping, are part of the metadata table. A fundamental tradeoff in any data system that supports indices is to balance the write throughput with index updates. A brute-force way is to lock out the writes while indexing. Hudi supports index creation using SQL, Datasource as well as async indexing. However, very large tables -can take hours to index. This is where Hudi's novel asynchronous metadata indexing comes into play. Indexes in Hudi are -created in two phases and uses a mix of optimistic concurrency control and log-based concurrency control models. The two +can take hours to index. This is where Hudi's novel asynchronous metadata indexing comes into play. + +## Asynchronous Metadata Indexing Review Comment: Let's call it concurrent indexing? ########## website/docs/sql_ddl.md: ########## @@ -283,13 +322,7 @@ DROP INDEX [IF EXISTS] index_name ON [TABLE] table_name - Both index and column on which the index is created can be qualified with some options in the form of key-value pairs. We will see this with an example of functional index below. -:::note -Except for the `files`, `column_stats`, `bloom_filters` and `record_index`, all other indexes are experimental. We -encourage users to try out these features on new tables and provide feedback. Below, we have also listed current -limitations of these indexes. -::: - -#### Create Functional Index (Experimental) +#### Create Functional Index Review Comment: let's make it Expression Index and add the sql and functions supported here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
