jonvex commented on code in PR #12422:
URL: https://github.com/apache/hudi/pull/12422#discussion_r1870026838


##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/dml/TestPartialUpdateForMergeInto.scala:
##########
@@ -66,6 +64,17 @@ class TestPartialUpdateForMergeInto extends 
HoodieSparkSqlTestBase {
     testPartialUpdateWithInserts("mor", "parquet")
   }
 
+  test("Test partial update with schema on read enabled") {

Review Comment:
   I didn't think it was worth it for CI time to test the other cases:
   The first 2 just check a table config and we have a ton of confidence that 
table config works correctly.
   The enum one should have the validation unit tested so I'll add that.
   And the one I did test was spark config propagation which we are less 
confident on. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to