yihua commented on code in PR #12424:
URL: https://github.com/apache/hudi/pull/12424#discussion_r1870545651
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/BaseActionExecutor.java:
##########
@@ -161,4 +162,20 @@ protected final void dropIndexOnRestore() {
}
}
}
+
+ protected final void maybeDisableWriteRecordPositions() {
Review Comment:
Doing it at the `HoodieAppendHandle` level requires instantiating and
scanning the timeline to find the compaction instant at every executor, which
is an overhead that should not be introduced I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
