linliu-code commented on code in PR #12433:
URL: https://github.com/apache/hudi/pull/12433#discussion_r1872039956


##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/DefaultSparkRecordMerger.java:
##########
@@ -48,31 +49,6 @@ public Option<Pair<HoodieRecord, Schema>> merge(HoodieRecord 
older, Schema oldSc
     ValidationUtils.checkArgument(older.getRecordType() == 
HoodieRecordType.SPARK);
     ValidationUtils.checkArgument(newer.getRecordType() == 
HoodieRecordType.SPARK);
 
-    if (newer instanceof HoodieSparkRecord) {

Review Comment:
   How about these merge logic in mergeHandles? Are we going to remove merger 
from them?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to