(hudi) branch master updated: [MINOR] Only getCompletionTime for completedInstants in TimelineUtils.getCommitsTimelineAfter (#12359)

[danny0405]

This is an automated email from the ASF dual-hosted git repository.

danny0405 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hudi.git


The following commit(s) were added to refs/heads/master by this push:
     new 65e7edb565d [MINOR] Only getCompletionTime for completedInstants in 
TimelineUtils.getCommitsTimelineAfter (#12359)
65e7edb565d is described below

commit 65e7edb565d7d144ed0d278b686bda5a80c7ea3e
Author: Zhaojing Yu <yuzhaoj...@bytedance.com>
AuthorDate: Tue Dec 10 10:21:50 2024 +0800

    [MINOR] Only getCompletionTime for completedInstants in 
TimelineUtils.getCommitsTimelineAfter (#12359)
    
    Co-authored-by: yuzhaojing <yuzhaoj...@kuaishou.com>
---
 .../main/java/org/apache/hudi/common/table/timeline/TimelineUtils.java   | 1 +
 .../src/test/java/org/apache/hudi/common/table/TestTimelineUtils.java    | 1 +
 2 files changed, 2 insertions(+)

diff --git 
a/hudi-common/src/main/java/org/apache/hudi/common/table/timeline/TimelineUtils.java
 
b/hudi-common/src/main/java/org/apache/hudi/common/table/timeline/TimelineUtils.java
index 42a92a453b6..7226a31ada8 100644
--- 
a/hudi-common/src/main/java/org/apache/hudi/common/table/timeline/TimelineUtils.java
+++ 
b/hudi-common/src/main/java/org/apache/hudi/common/table/timeline/TimelineUtils.java
@@ -313,6 +313,7 @@ public class TimelineUtils {
     if (lastMaxCompletionTime.isPresent()) {
       // Get 'hollow' instants that have less instant time than 
exclusiveStartInstantTime but with greater commit completion time
       HoodieTimeline hollowInstantsTimeline = ((HoodieTimeline) 
timeline).getCommitsTimeline()
+          .filterCompletedInstants()
           .filter(s -> compareTimestamps(s.requestedTime(), LESSER_THAN, 
exclusiveStartInstantTime))
           .filter(s -> compareTimestamps(s.getCompletionTime(), GREATER_THAN, 
lastMaxCompletionTime.get()));
       if (!hollowInstantsTimeline.empty()) {
diff --git 
a/hudi-hadoop-common/src/test/java/org/apache/hudi/common/table/TestTimelineUtils.java
 
b/hudi-hadoop-common/src/test/java/org/apache/hudi/common/table/TestTimelineUtils.java
index c8f5f6f5657..c58ba401994 100644
--- 
a/hudi-hadoop-common/src/test/java/org/apache/hudi/common/table/TestTimelineUtils.java
+++ 
b/hudi-hadoop-common/src/test/java/org/apache/hudi/common/table/TestTimelineUtils.java
@@ -311,6 +311,7 @@ public class TestTimelineUtils extends 
HoodieCommonTestHarness {
     String startTs = "010";
     HoodieTableMetaClient mockMetaClient = prepareMetaClient(
         Arrays.asList(
+            new HoodieInstant(INFLIGHT, COMMIT_ACTION, "008", null, 
InstantComparatorV2.REQUESTED_TIME_BASED_COMPARATOR),
             new HoodieInstant(COMPLETED, COMMIT_ACTION, "009", "013", 
InstantComparatorV2.REQUESTED_TIME_BASED_COMPARATOR),
             new HoodieInstant(COMPLETED, COMMIT_ACTION, "010", "010", 
InstantComparatorV2.REQUESTED_TIME_BASED_COMPARATOR),
             new HoodieInstant(COMPLETED, COMMIT_ACTION, "011", "011", 
InstantComparatorV2.REQUESTED_TIME_BASED_COMPARATOR),