xushiyan commented on code in PR #12223: URL: https://github.com/apache/hudi/pull/12223#discussion_r1878594957
########## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ########## @@ -39,7 +39,7 @@ import org.apache.hudi.common.model.HoodieFileFormat; import org.apache.hudi.common.model.HoodieFileGroup; import org.apache.hudi.common.model.HoodieIndexDefinition; -import org.apache.hudi.common.model.HoodieIndexMetadata; +import org.apache.hudi.common.model.HoodieIndexFunctionalOrSecondaryIndexMetadata; Review Comment: I don't think having "FunctionalOrSecondary" is a good idea in the class name to indicate usage for both indexes - it's lengthy and not abstracting anything. I think we should stick to the original `HoodieIndexMetadata` and add javadoc to clarify what that class is meant for. Btw, the latest name is Expression index, replacing Functional index. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
