TheR1sing3un commented on code in PR #12394:
URL: https://github.com/apache/hudi/pull/12394#discussion_r1881319681
##########
hudi-io/src/main/java/org/apache/hudi/storage/HoodieStorage.java:
##########
@@ -309,11 +309,15 @@ public final StorageConfiguration<?> getConf() {
@PublicAPIMethod(maturity = ApiMaturityLevel.EVOLVING)
public final void createImmutableFileInPath(StoragePath path,
Option<byte[]> content) throws
HoodieIOException {
+ createImmutableFileInPath(path, content, needCreateTempFile());
+ }
+
+ @PublicAPIMethod(maturity = ApiMaturityLevel.EVOLVING)
+ public final void createImmutableFileInPath(StoragePath path,
+ Option<byte[]> content, boolean
needTempFile) throws HoodieIOException {
OutputStream fsout = null;
StoragePath tmpPath = null;
- boolean needTempFile = needCreateTempFile();
Review Comment:
> We can not do this, the flag `isWriteTransactional` does not set up right
for many object stores. Let's just keep it as it is, local fs is only for
testing purpose so we should be good.
Got it! But can I just add a judgment of whether it's local fs or not?
Because ut's tests rely on local fs, if we do not add this judgment, ut will
have unexpected logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
