fhan688 commented on code in PR #12402:
URL: https://github.com/apache/hudi/pull/12402#discussion_r1881319868
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/HoodieDatasetBulkInsertHelper.scala:
##########
@@ -243,7 +243,7 @@ object HoodieDatasetBulkInsertHelper
private def getPartitionPathFields(config: HoodieWriteConfig):
mutable.Seq[String] = {
val keyGeneratorClassName =
config.getString(HoodieWriteConfig.KEYGENERATOR_CLASS_NAME)
- val keyGenerator = ReflectionUtils.loadClass(keyGeneratorClassName, new
TypedProperties(config.getProps)).asInstanceOf[BuiltinKeyGenerator]
+ val keyGenerator =
ReflectionUtils.loadClass(HoodieSparkKeyGeneratorFactory.convertToSparkKeyGenerator(keyGeneratorClassName),
new TypedProperties(config.getProps)).asInstanceOf[BuiltinKeyGenerator]
Review Comment:
> builtin ken generator is never expected to be specified by users right?
I think so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
