TheR1sing3un commented on code in PR #12389:
URL: https://github.com/apache/hudi/pull/12389#discussion_r1883171775
##########
hudi-io/src/main/java/org/apache/hudi/storage/HoodieStorage.java:
##########
@@ -370,7 +370,7 @@ public final void createImmutableFileInPath(StoragePath
path,
*/
@PublicAPIMethod(maturity = ApiMaturityLevel.EVOLVING)
public final boolean needCreateTempFile() {
- return StorageSchemes.HDFS.getScheme().equals(getScheme());
+ return StorageSchemes.HDFS.getScheme().equals(getScheme()) ||
StorageSchemes.FILE.getScheme().equals(getScheme());
Review Comment:
> Can we revert this change and just fix the unit tests.
OK, I will just fix ut but not change this method~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
