danny0405 commented on code in PR #12466:
URL: https://github.com/apache/hudi/pull/12466#discussion_r1886481103
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteOperatorCoordinator.java:
##########
@@ -590,6 +590,8 @@ private void doCommit(String instant, List<WriteStatus>
writeResults) {
reset();
this.ckpMetadata.commitInstant(instant);
LOG.info("Commit instant [{}] success!", instant);
+
this.flinkTimeLineMetrics.updateTimeLineMetrics(this.writeClient.getHoodieTable().getActiveTimeline());
Review Comment:
The `BaseHoodieClient` already got a `HoodieMetrics` instance, we can just
enhance it with new items or add the `FlinkTimeLineMetrics` in
`HoodieFlinkWriteClient`, and update it in `HoodieFlinkWriteClient.postCommit`,
you need to override the `#postCommit` method so that we can eliminate the
redundant timeline loading(file listing) for each commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
