geserdugarov commented on code in PR #12516:
URL: https://github.com/apache/hudi/pull/12516#discussion_r1893691006


##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/io/storage/row/HoodieRowDataCreateHandle.java:
##########
@@ -90,6 +91,7 @@ public HoodieRowDataCreateHandle(HoodieTable table, 
HoodieWriteConfig writeConfi
     this.fileId = fileId;
     this.newRecordLocation = new HoodieRecordLocation(instantTime, fileId);
     this.preserveHoodieMetadata = preserveHoodieMetadata;
+    this.skipMetadataWrite = skipMetadataWrite;

Review Comment:
   @danny0405 
   I've added `ITTestHoodieDataSource::testWriteWithoutMetaColumns`. But for 
proper checking, it would be great to write data by Flink, and then read it by 
Spark, because in Spark
   ```SQL
   SELECT * FROM table;
   ```
   will return all columns including those with metadata.
   And it would be really useful check of engines interoperability. I've 
created a corresponding task HUDI-8788.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to