danny0405 commented on code in PR #12531:
URL: https://github.com/apache/hudi/pull/12531#discussion_r1900526833
##########
hudi-common/src/main/java/org/apache/hudi/common/util/collection/RocksDBDAO.java:
##########
@@ -337,15 +332,58 @@ public <T extends Serializable> T get(String
columnFamilyName, String key) {
* @param <T> Type of object stored.
*/
public <K extends Serializable, T extends Serializable> T get(String
columnFamilyName, K key) {
+ return get(columnFamilyName, getKeyBytes(key));
+ }
+
+ /**
+ * Retrieve a value for a given key in a column family.
+ *
+ * @param columnFamilyName Column Family Name
+ * @param key Key to be retrieved
+ * @param <T> Type of object stored.
+ */
+ public <K extends Serializable, T extends Serializable> T get(String
columnFamilyName, byte[] key) {
ValidationUtils.checkArgument(!closed);
try {
- byte[] val = getRocksDB().get(managedHandlesMap.get(columnFamilyName),
SerializationUtils.serialize(key));
+ byte[] val = getRocksDB().get(managedHandlesMap.get(columnFamilyName),
key);
return val == null ? null : SerializationUtils.deserialize(val);
} catch (Exception e) {
throw new HoodieException(e);
}
}
+ /**
+ * Retrieve values for the given keys in a column family.
+ *
+ * @param columnFamilyName Column Family Name
+ * @param keys Keys to be retrieved
+ * @param <T> Type of object stored.
+ */
+ public <K extends Serializable, T extends Serializable> List<T>
multiGetAsList(String columnFamilyName, List<K> keys) {
Review Comment:
Remove the unused method.
##########
hudi-common/src/main/java/org/apache/hudi/common/util/collection/RocksDBDAO.java:
##########
@@ -337,15 +332,58 @@ public <T extends Serializable> T get(String
columnFamilyName, String key) {
* @param <T> Type of object stored.
*/
public <K extends Serializable, T extends Serializable> T get(String
columnFamilyName, K key) {
+ return get(columnFamilyName, getKeyBytes(key));
+ }
+
+ /**
+ * Retrieve a value for a given key in a column family.
+ *
+ * @param columnFamilyName Column Family Name
+ * @param key Key to be retrieved
+ * @param <T> Type of object stored.
+ */
+ public <K extends Serializable, T extends Serializable> T get(String
columnFamilyName, byte[] key) {
ValidationUtils.checkArgument(!closed);
try {
- byte[] val = getRocksDB().get(managedHandlesMap.get(columnFamilyName),
SerializationUtils.serialize(key));
+ byte[] val = getRocksDB().get(managedHandlesMap.get(columnFamilyName),
key);
return val == null ? null : SerializationUtils.deserialize(val);
} catch (Exception e) {
throw new HoodieException(e);
}
}
+ /**
+ * Retrieve values for the given keys in a column family.
+ *
+ * @param columnFamilyName Column Family Name
+ * @param keys Keys to be retrieved
+ * @param <T> Type of object stored.
+ */
+ public <K extends Serializable, T extends Serializable> List<T>
multiGetAsList(String columnFamilyName, List<K> keys) {
+ List<byte[]> byteKeys =
keys.stream().map(this::getKeyBytes).collect(Collectors.toList());
+ ColumnFamilyHandle handle = managedHandlesMap.get(columnFamilyName);
+ ValidationUtils.checkArgument(handle != null, "Column Family not found :"
+ columnFamilyName);
+ List<ColumnFamilyHandle> columnFamilyHandles = byteKeys.stream().map(key
-> handle).collect(Collectors.toList());
+ return multiGetAsList(columnFamilyHandles, byteKeys);
+ }
+
+ /**
+ * Retrieve values for the given keys in the given column families.
+ *
+ * @param columnFamilyHandles Column Family Handles
+ * @param keys Keys to be retrieved
+ * @param <T> Type of object stored.
+ */
+ private <T extends Serializable> List<T>
multiGetAsList(List<ColumnFamilyHandle> columnFamilyHandles, List<byte[]> keys)
{
Review Comment:
Remove the unused method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
