the-other-tim-brown commented on code in PR #12562:
URL: https://github.com/apache/hudi/pull/12562#discussion_r1900894155
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -329,6 +316,23 @@ private void saveInternalSchema(HoodieTable table, String
instantTime, HoodieCom
}
}
+ void runTableServicesInline(Option<Map<String, String>> extraMetadata,
HoodieTable table, HoodieCommitMetadata metadata) {
+ // We don't want to fail the commit if
hoodie.fail.writes.on.inline.table.service.exception is false. We catch warn if
false
+ try {
+ // trigger clean and archival.
+ // Each internal call should ensure to lock if required.
+ mayBeCleanAndArchive(table);
+ // do this outside of lock since compaction, clustering can be time
taking and we don't need a lock for the entire execution period
+ runCompactionClusteringInline(table, metadata, extraMetadata);
+ } catch (Exception e) {
+ if (config.isFailOnInlineTableServiceExceptionEnabled()) {
+ throw e;
+ }
+ LOG.warn("Inline table services failed with exception: " + e.getMessage()
Review Comment:
This log will lose all the context of the exception. When logging a warning,
you can also include the exception as the last arg so you can view the
stacktrace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
