nsivabalan commented on code in PR #12529:
URL: https://github.com/apache/hudi/pull/12529#discussion_r1901443447
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -1683,11 +1688,11 @@ private static Comparable<?> coerceToComparable(Schema
schema, Object val) {
}
private static boolean isColumnTypeSupported(Schema schema,
Option<HoodieRecordType> recordType) {
- // if record type is set and if its AVRO, MAP is unsupported.
- if (recordType.isPresent() && recordType.get() == HoodieRecordType.AVRO) {
+ // if record type is not set or if its AVRO, MAP is unsupported.
+ if (!recordType.isPresent() || recordType.get() == HoodieRecordType.AVRO) {
Review Comment:
we have lot of cases covered in
https://github.com/apache/hudi/blob/dbd5a71a0e274a7d1d28da29056cbcc31477bcc9/hudi-hadoop-common/src/test/java/org/apache/hudi/metadata/TestHoodieTableMetadataUtil.java#L369.
for nested fields, we do have a functional test in TestHoodieColStats but
not as UT. will add them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
