yihua commented on code in PR #12570:
URL: https://github.com/apache/hudi/pull/12570#discussion_r1902242352
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -584,12 +584,13 @@ protected void runTableServicesInline(HoodieTable table,
HoodieCommitMetadata me
// do this outside of lock since compaction, clustering can be time
taking and we don't need a lock for the entire execution period
runTableServicesInlineInternal(table, metadata, extraMetadata);
} catch (Throwable t) {
- LOG.error(String.format("Inline compaction or clustering failed for
table {}.", table.getConfig().getBasePath()), t);
// Throw if this is exception and the exception is configured to throw
or if it is something else like Error.
if (config.isFailOnInlineTableServiceExceptionEnabled() || !(t
instanceof Exception)) {
+ LOG.error("Inline compaction or clustering failed for table {}.",
table.getConfig().getBasePath(), t);
throw t;
}
- LOG.warn("Inline compaction or clustering failed. Moving further since
\"hoodie.fail.writes.on.inline.table.service.exception\" is set to false.", t);
+ LOG.warn("Inline compaction or clustering failed table {}. Moving
further since "
Review Comment:
```suggestion
LOG.warn("Inline compaction or clustering failed for table {}. Moving
further since "
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
