dugenkui03 commented on a change in pull request #2115:
URL: https://github.com/apache/hudi/pull/2115#discussion_r497315599
##########
File path:
hudi-client/src/main/java/org/apache/hudi/async/AbstractAsyncService.java
##########
@@ -39,9 +39,9 @@
private static final Logger LOG =
LogManager.getLogger(AbstractAsyncService.class);
// Flag to track if the service is started.
- private boolean started;
+ private volatile boolean started;
Review comment:
I think `started ` will be read by multiple thread, so it is necessary
to guarantee the visibility of `start`. As well as `shutdownRequested `.
May be I misunderstand the usage scenario of them. I convert this PR to
draft for the moment, until i make sure that this change is necessary or not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
