codope commented on code in PR #12525:
URL: https://github.com/apache/hudi/pull/12525#discussion_r1904129984
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1160,17 +1159,19 @@ private void
updateSecondaryIndexIfPresent(HoodieCommitMetadata commitMetadata,
private HoodieData<HoodieRecord>
getSecondaryIndexUpdates(HoodieCommitMetadata commitMetadata, String
indexPartition, String instantTime) throws Exception {
List<Pair<String, Pair<String, List<String>>>> partitionFilePairs =
getPartitionFilePairs(commitMetadata);
+ if (partitionFilePairs.isEmpty()) {
+ return engineContext.emptyHoodieData();
+ }
// Build a list of keys that need to be removed. A 'delete' record will be
emitted into the respective FileGroup of
// the secondary index partition for each of these keys.
- List<String> keysToRemove =
HoodieTableMetadataUtil.getRecordKeysDeletedOrUpdated(engineContext,
commitMetadata, dataWriteConfig.getMetadataConfig(),
- dataMetaClient, instantTime);
+ HoodieData<String> keysToRemove =
getRecordKeysDeletedOrUpdated(engineContext, commitMetadata,
dataWriteConfig.getMetadataConfig(), dataMetaClient, instantTime);
Review Comment:
Now, the SI logic is also optimized which does not use this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
