yihua commented on code in PR #12576:
URL: https://github.com/apache/hudi/pull/12576#discussion_r1904465382
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/dml/TestMergeIntoTable.scala:
##########
@@ -1364,16 +1364,21 @@ class TestMergeIntoTable extends HoodieSparkSqlTestBase
with ScalaAssertionSuppo
spark.sql(
s"""
- | merge into $tableName as t0
- | using (
- | select 2 as id, 'a2' as name, 10 as price, '2021-03-20' as dt
- | ) s0
- | on s0.id = t0.id
- | when not matched and s0.id % 2 = 0 then insert (id, name, dt)
- | values(s0.id, s0.name, s0.dt)
- """.stripMargin)
+ |MERGE INTO $tableName AS t0
+ |USING (
+ | SELECT 2 as id, 'a2' as name, 10 as price, '2021-03-20' as dt
+ | UNION
+ | SELECT 1 as id, 'a3' as name, 11 as price, null as dt
Review Comment:
`null as dt`: the partition should not be null in this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
