nsivabalan commented on code in PR #12579:
URL: https://github.com/apache/hudi/pull/12579#discussion_r1904671861
##########
hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java:
##########
@@ -676,13 +676,15 @@ public static Schema
getNestedFieldSchemaFromRecord(GenericRecord record, String
*/
public static Schema getNestedFieldSchemaFromWriteSchema(Schema writeSchema,
String fieldName) {
String[] parts = fieldName.split("\\.");
- int i = 0;
- for (; i < parts.length; i++) {
+ Schema currentSchema = writeSchema;
Review Comment:
don't we have UTs for getNestedFieldSchemaFromWriteSchema ?
can we add one and add some tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
