wangxianghu commented on pull request #1827:
URL: https://github.com/apache/hudi/pull/1827#issuecomment-702308385
> > @wangxianghu can you please test the latest commit. To be clear, you are
saying you don't get the warning on master, but get it on this branch. right?
> > if this round of tests pass, and you confirm, we can land from my
perspective
>
> Hi @vinothchandar The warn log is still there in HUDI-1089 branch.(master
is ok, no warn log)
> I think we should check `embeddedTimelineServiceHostAddr` instead of
`hostAddr`.
>
> ```
> private void setHostAddr(String embeddedTimelineServiceHostAddr) {
> // here we should check embeddedTimelineServiceHostAddr instead of
hostAddr
> if (hostAddr != null) {
> LOG.info("Overriding hostIp to (" + embeddedTimelineServiceHostAddr
+ ") found in spark-conf. It was " + this.hostAddr);
> this.hostAddr = embeddedTimelineServiceHostAddr;
> } else {
> LOG.warn("Unable to find driver bind address from spark config");
> this.hostAddr = NetworkUtils.getHostname();
> }
> }
> ```
I have tested the latest commit with the check condition changed to
```
if (embeddedTimelineServiceHostAddr != null) {
````
It runs well in my local, and the warn log disappeared.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
