yihua commented on code in PR #12602:
URL: https://github.com/apache/hudi/pull/12602#discussion_r1908006850
##########
hudi-spark-datasource/hudi-spark/src/main/java/org/apache/hudi/HoodieDataSourceHelpers.java:
##########
@@ -98,6 +106,20 @@ public static String latestCommit(HoodieStorage storage,
String basePath) {
return timeline.lastInstant().get().requestedTime();
}
+ /**
+ * Returns the last successful write operation's completed instant.
+ */
+ @PublicAPIMethod(maturity = ApiMaturityLevel.EVOLVING)
+ public static HoodieInstant latestCompletedCommitCompletionTime(FileSystem
fs, String basePath) {
Review Comment:
```suggestion
public static HoodieInstant latestCompletedCommit(FileSystem fs, String
basePath) {
```
##########
hudi-spark-datasource/hudi-spark/src/main/java/org/apache/hudi/HoodieDataSourceHelpers.java:
##########
@@ -98,6 +106,20 @@ public static String latestCommit(HoodieStorage storage,
String basePath) {
return timeline.lastInstant().get().requestedTime();
}
+ /**
+ * Returns the last successful write operation's completed instant.
+ */
+ @PublicAPIMethod(maturity = ApiMaturityLevel.EVOLVING)
+ public static HoodieInstant latestCompletedCommitCompletionTime(FileSystem
fs, String basePath) {
+ HoodieTimeline timeline = allCompletedCommitsCompactions(fs, basePath);
+ return timeline.lastInstant().get();
+ }
+
+ public static HoodieInstant
latestCompletedCommitCompletionTime(HoodieStorage storage, String basePath) {
Review Comment:
```suggestion
public static HoodieInstant latestCompletedCommit(HoodieStorage storage,
String basePath) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
