danny0405 commented on code in PR #12598:
URL: https://github.com/apache/hudi/pull/12598#discussion_r1908311946
##########
hudi-common/src/main/java/org/apache/hudi/avro/AvroSchemaUtils.java:
##########
@@ -605,14 +605,16 @@ public static String createSchemaErrorString(String
errorMessage, Schema writerS
* @param nullable nullability of column type
* @return a new schema with the nullabilities of the given columns updated
*/
- public static Schema createSchemaWithNullabilityUpdate(
+ public static Schema forceNullableColumns(
Schema schema, List<String> nullableUpdateCols, boolean nullable) {
Review Comment:
nullableUpdateCols -> columns. We can eliminate the flag `nullalbe` because
it is always true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
