nsivabalan commented on code in PR #12594:
URL: https://github.com/apache/hudi/pull/12594#discussion_r1911151444
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java:
##########
@@ -487,9 +492,17 @@ protected void
appendDataAndDeleteBlocks(Map<HeaderMetadataType, String> header,
getUpdatedHeader(header, config), keyField));
}
+ if (shouldWriteRecordPositions
+ && !recordsToDeleteWithPositions.isEmpty()
+ && StringUtils.isNullOrEmpty(baseFileInstantTimeForDeletePositions))
{
+ LOG.warn("Base file instant time of delete positions cannot be
determined, possibly "
+ + "due to inserts or different base file instant times for the
input records.");
+ }
+
if (appendDeleteBlocks && !recordsToDeleteWithPositions.isEmpty()) {
- blocks.add(new HoodieDeleteBlock(recordsToDeleteWithPositions,
shouldWriteRecordPositions,
- getUpdatedHeader(header, config)));
+ blocks.add(new HoodieDeleteBlock(
+ recordsToDeleteWithPositions,
baseFileInstantTimeForDeletePositions,
Review Comment:
can you help me locate where we do add the base instant time for data block
headers?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
