yihua commented on code in PR #12569:
URL: https://github.com/apache/hudi/pull/12569#discussion_r1913879619
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/KafkaSource.java:
##########
@@ -75,6 +78,11 @@ protected InputBatch<T>
readFromCheckpoint(Option<Checkpoint> lastCheckpoint, lo
lastCheckpoint, sourceLimit));
} catch (org.apache.kafka.common.errors.TimeoutException e) {
throw new HoodieSourceTimeoutException("Kafka Source timed out " +
e.getMessage());
+ } catch (KafkaException ex) {
+ if (hasConfigException(ex)) {
+ throw new HoodieSourceConfigException("kafka source config issue ",
ex);
+ }
+ throw ex;
Review Comment:
I think it is better to reuse the exception if that's sufficient. If a new
specific exception class is really needed, you can change it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
