geserdugarov commented on code in PR #12630:
URL: https://github.com/apache/hudi/pull/12630#discussion_r1914647095
##########
pom.xml:
##########
@@ -2633,14 +2633,14 @@
<profile>
<id>java17</id>
+ <activation>
+ <jdk>[17,)</jdk>
+ </activation>
<properties>
+ <!-- to check during compilation that we didn't use APIs that don't
exist in previous releases, remove after drop support of JDK 8 -->
+ <maven.compiler.release>8</maven.compiler.release>
Review Comment:
This was done corresponding to Maven doc:
https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-release.html
We have maven-compiler-plugin 3.8.0, so it's enough to set property
`maven.compiler.release`.
And we need to use `release` option to check that we didn't use APIs that
don't exist in previous Java releases.
Also, there is a lot of confusion around `source`, `target`, and `release`.
For this reason corresponding changes in JDK has been done:
https://bugs.openjdk.org/browse/JDK-8308399
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
