danny0405 commented on code in PR #12608:
URL: https://github.com/apache/hudi/pull/12608#discussion_r1917551731
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieUnMergedLogRecordScanner.java:
##########
@@ -111,6 +118,32 @@ public interface RecordDeletionCallback {
void apply(HoodieKey deletedKey);
}
+ /**
+ * Returns an iterator over the log records.
+ */
+ public Iterator<HoodieRecord<?>> iterator() {
+ List<HoodieRecord<?>> records = new ArrayList<>();
Review Comment:
Can we try to eliminate the list and return a nested iterator if possible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
