TheR1sing3un commented on code in PR #12627:
URL: https://github.com/apache/hudi/pull/12627#discussion_r1917834038
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/bucket/BucketIdentifier.java:
##########
@@ -115,6 +115,13 @@ private static String newBucketFileIdFixedSuffix(int
bucketId) {
return newBucketFileIdFixedSuffix(bucketIdStr(bucketId));
}
+ /**
+ * Generate a new file id for NBCC mode, file id is fixed for each bucket
with format: "{bucket_id}-0000-0000-0000-000000000000-0"
+ */
+ public static String newBucketFileIdForNBCC(int bucketId) {
+ return FSUtils.createNewFileId(newBucketFileIdFixedSuffix(bucketId), 0);
Review Comment:
> Is the change compatible with existing behavior?
The bucket with existing data will be written with the existing file name.
Only the newly added bucket will use the new name, which does not cause
compatibility problems
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
