xushiyan commented on a change in pull request #2143:
URL: https://github.com/apache/hudi/pull/2143#discussion_r499320666
##########
File path:
hudi-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestTable.java
##########
@@ -348,12 +372,36 @@ public String getBaseFileNameById(String fileId) {
return baseFileName(currentInstantTime, fileId);
}
- public List<FileStatus> listAllFiles(String partitionPath) throws
IOException {
- return FileSystemTestUtils.listRecursive(fs, new Path(Paths.get(basePath,
partitionPath).toString()));
+ public FileStatus[] listAllBaseFiles() throws IOException {
+ return listAllBaseFiles(HoodieFileFormat.PARQUET.getFileExtension());
+ }
+
+ public FileStatus[] listAllBaseFiles(String fileExtension) throws
IOException {
+ return FileSystemTestUtils.listRecursive(fs, new Path(basePath)).stream()
+ .filter(status -> status.getPath().getName().endsWith(fileExtension))
+ .toArray(FileStatus[]::new);
+ }
+
+ public FileStatus[] listAllLogFiles() throws IOException {
+ return listAllLogFiles(HoodieFileFormat.HOODIE_LOG.getFileExtension());
+ }
+
+ public FileStatus[] listAllLogFiles(String fileExtension) throws IOException
{
+ return FileSystemTestUtils.listRecursive(fs, new Path(basePath)).stream()
+ .filter(status -> status.getPath().getName().contains(fileExtension))
+ .toArray(FileStatus[]::new);
+ }
+
+ public FileStatus[] listAllBaseAndLogFiles() throws IOException {
+ return Stream.concat(Stream.of(listAllBaseFiles()),
Stream.of(listAllLogFiles())).toArray(FileStatus[]::new);
+ }
+
+ public FileStatus[] listAllFilesInPartition(String partitionPath) throws
IOException {
+ return FileSystemTestUtils.listRecursive(fs, new Path(Paths.get(basePath,
partitionPath).toString())).toArray(new FileStatus[0]);
}
- public List<FileStatus> listAllFilesInTempFolder() throws IOException {
- return FileSystemTestUtils.listRecursive(fs, new Path(Paths.get(basePath,
HoodieTableMetaClient.TEMPFOLDER_NAME).toString()));
+ public FileStatus[] listAllFilesInTempFolder() throws IOException {
+ return FileSystemTestUtils.listRecursive(fs, new Path(Paths.get(basePath,
HoodieTableMetaClient.TEMPFOLDER_NAME).toString())).toArray(new FileStatus[0]);
Review comment:
change to return array to work with `HoodieTableFileSystemView` APIs
which take in array
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
