fhan688 commented on code in PR #12644:
URL: https://github.com/apache/hudi/pull/12644#discussion_r1919471590
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/CompactionUtil.java:
##########
@@ -149,14 +149,14 @@ public static void rollbackCompaction(HoodieFlinkTable<?>
table, String instantT
*
* @param table The hoodie table
*/
- public static void rollbackCompaction(HoodieFlinkTable<?> table) {
+ public static void rollbackCompaction(HoodieFlinkTable<?> table,
HoodieFlinkWriteClient writeClient) {
HoodieTimeline inflightCompactionTimeline = table.getActiveTimeline()
.filterPendingCompactionTimeline()
.filter(instant ->
instant.getState() == HoodieInstant.State.INFLIGHT);
inflightCompactionTimeline.getInstants().forEach(inflightInstant -> {
LOG.info("Rollback the inflight compaction instant: " + inflightInstant
+ " for failover");
- table.rollbackInflightCompaction(inflightInstant);
+ table.rollbackInflightCompaction(inflightInstant, commitToRollback ->
writeClient.getTableServiceClient().getPendingRollbackInfo(table.getMetaClient(),
commitToRollback, false));
Review Comment:
yes, I agree
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
