codope commented on code in PR #12622:
URL: https://github.com/apache/hudi/pull/12622#discussion_r1919867111
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/HoodieFileGroupReaderBasedParquetFileFormat.scala:
##########
@@ -277,7 +279,7 @@ class
HoodieFileGroupReaderBasedParquetFileFormat(tableState: HoodieTableState,
}
}
- private def readBaseFile(file: PartitionedFile, parquetFileReader:
SparkParquetReader, requestedSchema: StructType,
+ private def readBaseFile(file: PartitionedFile, parquetFileReader:
SparkFileReader, requestedSchema: StructType,
Review Comment:
This is what I had in mind: we can rename this class to
`HoodieFileGroupReaderBasedFileFormat` and make this method extensible. From
this class, we have two child classes for
HoodieFileGroupReaderBasedFileParquetFormat
andHoodieFileGroupReaderBasedOrcFileFormat, which only need to override
`readBaseFile`. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
