codope commented on code in PR #12653:
URL: https://github.com/apache/hudi/pull/12653#discussion_r1922051061
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/index/ScheduleIndexActionExecutor.java:
##########
@@ -133,6 +133,7 @@ public Option<HoodieIndexPlan> execute() {
private HoodieIndexPartitionInfo
buildIndexPartitionInfo(MetadataPartitionType partitionType, HoodieInstant
indexUptoInstant) {
// for expression index, we need to pass the index name as the partition
name
+ // TODO: see the index partition info is built correctly. Should we
register the index here?
Review Comment:
removing the TODO. It was just an initial approach I was trying to hash out.
But, it is not needed anymore. Both the indexer, sql utilately pass through
`HoodieBackedTableMetadataWriter.initializeFromFileSystem` and I have handled
it there.
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java:
##########
@@ -352,6 +358,32 @@ public final class HoodieMetadataConfig extends
HoodieConfig {
.sinceVersion("1.0.0")
.withDocumentation("Parallelism to use, when generating expression
index.");
+ public static final ConfigProperty<String> EXPRESSION_INDEX_COLUMN =
ConfigProperty
+ .key(METADATA_PREFIX + ".index.expression.column")
+ .noDefaultValue()
+ .markAdvanced()
+ .sinceVersion("1.0.0")
Review Comment:
good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
