nsivabalan commented on code in PR #12662:
URL: https://github.com/apache/hudi/pull/12662#discussion_r1923045004
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -2040,15 +2041,19 @@ public boolean useBloomIndexBucketizedChecking() {
}
public boolean isMetadataBloomFilterIndexEnabled() {
- return isMetadataTableEnabled() &&
getMetadataConfig().isBloomFilterIndexEnabled();
+ return isMetadataTableEnabled() &&
getMetadataConfig().isBloomFilterIndexEnabled() ||
!isDropMetadataIndex(MetadataPartitionType.BLOOM_FILTERS.getPartitionPath());
Review Comment:
why OR condition. it should be AND right?
can you update PR desc w/ more illustration.
how does one set mdt configs for inline and async flows. and how does
deletion of indexes work prior to this patch. and how does it work w/ this
patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
