lw309637554 commented on pull request #2136: URL: https://github.com/apache/hudi/pull/2136#issuecomment-704201612
> > @lw309637554 Change itself looks good to me. However, wondering if we should also > > > > * Add some check to throw an error if the index type is different in `hoodie.properties` than it's configured. some changes are compatible for e.g using `GLOBAL_BLOOM` and then switching to `BLOOM`/`SIMPLE` . but reverse is not. add compatible check in AbstractHoodieClient.createMetaClient(). now check the case you mentioned, if have other case need to add ? > > * I think it's high time we introduce a builder pattern init the table properties. those overloaded `initXX` are hard to read. If interested, we can do that in a separate PR. i will land it in https://issues.apache.org/jira/browse/HUDI-1315 > > * Should we also add something to upgrade downgrade logic to persist this for existing datasets. yeah have add in AbstractUpgradeDowngrade.createUpdatedFile() > > Thanks , i will think about ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
