HuangZhenQiu commented on code in PR #12666:
URL: https://github.com/apache/hudi/pull/12666#discussion_r1925929969
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteOperatorCoordinator.java:
##########
@@ -473,6 +475,19 @@ private void handleEndInputEvent(WriteMetadataEvent event)
{
}
}
+ private void filterWriteFailure(WriteMetadataEvent event) throws
HoodieException {
Review Comment:
It is a good suggestion. The logical of detecting write failures is actually
one single line with stream API. I feel it is overkill to create a separate
function for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
