codope commented on code in PR #12653:
URL: https://github.com/apache/hudi/pull/12653#discussion_r1926590385
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1050,6 +1037,7 @@ private Set<String> getMetadataPartitionsToUpdate() {
}
public void buildMetadataPartitions(HoodieEngineContext engineContext,
List<HoodieIndexPartitionInfo> indexPartitionInfos, String instantTime) throws
IOException {
+ // TODO: so we need to create an index definition in case we're coming via
the indexer
Review Comment:
This TODO is no longer required. Both the indexer and regular writer
eventually call `initializeFromFilesystem`, so the check to initialize new
SI/EI is deferred to `initializeFromFilesystem`. Will remove the TODO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
