yihua commented on code in PR #12692:
URL: https://github.com/apache/hudi/pull/12692#discussion_r1928413092
##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/analysis/HoodieAnalysis.scala:
##########
@@ -46,6 +46,11 @@ object HoodieAnalysis extends SparkAdapterSupport {
def customResolutionRules: Seq[RuleBuilder] = {
val rules: ListBuffer[RuleBuilder] = ListBuffer()
+ if (HoodieSparkUtils.gteqSpark3_5) {
+ rules += (_ => instantiateKlass(
+
"org.apache.spark.sql.hudi.analysis.HoodieSpark35ResolveColumnsForInsertInto"))
Review Comment:
Regarding this one, I'm keeping the logic as they are still required by
Spark 3.4. On Spark 3.5, after applying the new resolution rule
`HoodieSpark35ResolveColumnsForInsertInto`, `userSpecifiedCols` is reset to
empty, so essentially the projection in `ResolveImplementationsEarly` is not
invoked any more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
