codope commented on code in PR #12711:
URL: https://github.com/apache/hudi/pull/12711#discussion_r1930122279
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataWriter.java:
##########
@@ -61,17 +59,6 @@ public interface HoodieTableMetadataWriter extends
Serializable, AutoCloseable {
*/
void update(HoodieCommitMetadata commitMetadata, String instantTime);
- /**
- * Update the metadata table due to a COMMIT or REPLACECOMMIT operation.
- * As compared to {@link #update(HoodieCommitMetadata, String)}, this method
- * directly updates metadata with the given records, instead of generating
HoodieRecords based on HoodieCommitMetadata.
- *
- * @param commitMetadata commit metadata of the operation of interest.
- * @param records records to update metadata with.
- * @param instantTime instant time of the commit.
- */
- void update(HoodieCommitMetadata commitMetadata, HoodieData<HoodieRecord>
records, String instantTime);
Review Comment:
this API is no longer used.. so cleaned up a bit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
