Davis-Zhang-Onehouse commented on code in PR #12688:
URL: https://github.com/apache/hudi/pull/12688#discussion_r1930893430
##########
hudi-common/src/main/java/org/apache/hudi/common/table/checkpoint/CheckpointUtils.java:
##########
@@ -49,14 +59,15 @@ public static Checkpoint getCheckpoint(HoodieCommitMetadata
commitMetadata) {
throw new HoodieException("Checkpoint is not found in the commit metadata:
" + commitMetadata.getExtraMetadata());
}
- public static boolean targetCheckpointV2(int writeTableVersion) {
- return writeTableVersion >= HoodieTableVersion.EIGHT.versionCode();
+ public static boolean targetCheckpointV2(int writeTableVersion, String
sourceClassName) {
+ return writeTableVersion >= HoodieTableVersion.EIGHT.versionCode()
+ && !DATASOURCES_MUST_USE_CKP_V1.contains(sourceClassName);
}
// TODO(yihua): for checkpoint translation, handle cases where the
checkpoint is not exactly the
// instant or completion time
public static StreamerCheckpointV2 convertToCheckpointV2ForCommitTime(
- Checkpoint checkpoint, HoodieTableMetaClient metaClient) {
+ Checkpoint checkpoint, HoodieTableMetaClient metaClient,
TimelineUtils.HollowCommitHandling handlingMode) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
