nsivabalan commented on code in PR #12568:
URL: https://github.com/apache/hudi/pull/12568#discussion_r1932829334
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/BaseRollbackHelper.java:
##########
@@ -116,8 +118,10 @@ List<Pair<String, HoodieRollbackStat>>
maybeDeleteAndCollectStats(HoodieEngineCo
HoodieInstant instantToRollback,
List<SerializableHoodieRollbackRequest> rollbackRequests,
boolean
doDelete, int numPartitions) {
+ List<SerializableHoodieRollbackRequest> groupedRollbackRequests =
+ groupSerializableRollbackRequestsBasedOnFileGroup(rollbackRequests);
final TaskContextSupplier taskContextSupplier =
context.getTaskContextSupplier();
- return context.flatMap(rollbackRequests,
(SerializableFunction<SerializableHoodieRollbackRequest, Stream<Pair<String,
HoodieRollbackStat>>>) rollbackRequest -> {
+ return context.flatMap(groupedRollbackRequests,
(SerializableFunction<SerializableHoodieRollbackRequest, Stream<Pair<String,
HoodieRollbackStat>>>) rollbackRequest -> {
Review Comment:
can we try to limit the scope of the changes only to tbl version 6.
in tbl version 8, we don't need this since log files are going to be deleted
during rollback execution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
