nsivabalan commented on code in PR #12597:
URL: https://github.com/apache/hudi/pull/12597#discussion_r1933102292
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieBaseFileGroupRecordBuffer.java:
##########
@@ -576,15 +577,25 @@ private boolean isDeleteRecordWithNaturalOrder(Option<T>
rowOption,
}
private boolean isDeleteRecord(Option<T> record, Schema schema) {
+ // Case 1: no data.
if (record.isEmpty()) {
return true;
}
-
+ // Case 2: is a delete operation.
Object operation = readerContext.getValue(record.get(), schema,
OPERATION_METADATA_FIELD);
if (operation != null &&
HoodieOperation.isDeleteRecord(operation.toString())) {
return true;
}
-
+ // Case 3: is a custom delete.
+ boolean isDeleted = HoodieRecordUtils.isCustomDeleteRecord(
Review Comment:
can we check for custom delete properties in the constructor once and bypass
this check at a per record level?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
