codope commented on code in PR #12726:
URL: https://github.com/apache/hudi/pull/12726#discussion_r1933124938


##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/dml/TestMergeIntoTable2.scala:
##########
@@ -1216,4 +1216,88 @@ class TestMergeIntoTable2 extends HoodieSparkSqlTestBase 
{
       }
     })
   }
+
+  test("Test MergeInto with commit time/event time ordering coverage") {
+    Seq("cow", "mor").foreach { tableType =>
+      withTempDir { tmp =>
+        Seq(RecordMergeMode.COMMIT_TIME_ORDERING.name(),
+          RecordMergeMode.EVENT_TIME_ORDERING.name()).foreach { 
recordMergeMode =>

Review Comment:
   There was a case for CUSTOM merge mode as well, with FirstValueAvroPayload? 
Let's add that as well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to