wangxianghu commented on a change in pull request #2156:
URL: https://github.com/apache/hudi/pull/2156#discussion_r502330221
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/commit/AbstractWriteHelper.java
##########
@@ -79,7 +79,7 @@ public I combineOnCondition(
*
* @param records hoodieRecords to deduplicate
* @param parallelism parallelism or partitions to be used while
reducing/deduplicating
- * @return RDD of HoodieRecord already be deduplicated
+ * @return Collection of HoodieRecord already be deduplicated
*/
public I deduplicateRecords(
I records, HoodieTable<T, I, K, O> table, int parallelism) {
Review comment:
> Agree to remove the legacy comment for `HoodieIndexUtils `. IMO, we
can remain the comment in `HoodieWriteConfig` as a description of that config
option.
Yes, thanks for addressing my concern.
LGTM now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
