yihua commented on code in PR #12594:
URL: https://github.com/apache/hudi/pull/12594#discussion_r1933698519
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestMORDataSourceStorage.scala:
##########
@@ -311,8 +310,7 @@ class TestMORDataSourceStorage extends
SparkClientFunctionalTestHarness {
// since it happens before the compaction is executed.
// The deltacommit from the fifth and sixth round should write record
positions in the log
// files since it happens after the completed compaction
- validateRecordPositionsInLogFiles(
- metaClient, shouldContainRecordPosition = !enableNBCC && i != 4)
+ validateRecordPositionsInLogFiles(metaClient,
shouldContainRecordPosition = !enableNBCC)
Review Comment:
I've added stricter validation on the base file instant time of the record
positions in this test. Also, without the fix in the file group record buffer
to compare the base file instant times in the log header vs the actual base
file (`HoodiePositionBasedFileGroupRecordBuffer#extractRecordPositions`), this
test would fail because of the wrong results. So we should be good now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
