yihua commented on code in PR #12597:
URL: https://github.com/apache/hudi/pull/12597#discussion_r1934856289
##########
hudi-common/src/main/java/org/apache/hudi/common/model/BaseAvroPayload.java:
##########
@@ -68,7 +73,21 @@ public Comparable getOrderingVal() {
* We will not do deserialization in this method.
*/
public boolean isDeleted(Schema schema, Properties props) {
- return isDeletedRecord;
+ return isDeletedRecord
+ || HoodieRecordUtils.isCustomDeleteRecord(
+ recordBytes,
+ schema,
+ props,
+ recordData -> {
+ try {
+ GenericRecord data = HoodieAvroUtils.bytesToAvro(recordData,
schema);
Review Comment:
We should not deserialize the record bytes here, which causes significant
overhead per record. Only determine `isDeletedRecord` inside the constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
