danny0405 commented on code in PR #12568:
URL: https://github.com/apache/hudi/pull/12568#discussion_r1934947281
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/BaseRollbackHelper.java:
##########
@@ -116,8 +118,13 @@ List<Pair<String, HoodieRollbackStat>>
maybeDeleteAndCollectStats(HoodieEngineCo
HoodieInstant instantToRollback,
List<SerializableHoodieRollbackRequest> rollbackRequests,
boolean
doDelete, int numPartitions) {
+ // The rollback requests for append only exist in table version 6 and
below which require groupBy
+ List<SerializableHoodieRollbackRequest> processedRollbackRequests =
+
metaClient.getTableConfig().getTableVersion().greaterThanOrEquals(HoodieTableVersion.EIGHT)
+ ? rollbackRequests
Review Comment:
Does the issue exist for 0.x release, is it a logic miss for compatibility
migration?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
