vinothchandar commented on a change in pull request #2064:
URL: https://github.com/apache/hudi/pull/2064#discussion_r501943042
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieMergedLogRecordScanner.java
##########
@@ -57,41 +57,58 @@
private static final Logger LOG =
LogManager.getLogger(HoodieMergedLogRecordScanner.class);
// Final map of compacted/merged records
- private final ExternalSpillableMap<String, HoodieRecord<? extends
HoodieRecordPayload>> records;
+ protected final ExternalSpillableMap<String, HoodieRecord<? extends
HoodieRecordPayload>> records;
// count of merged records in log
private long numMergedRecordsInLog;
-
+ private long maxMemorySizeInBytes;
// Stores the total time taken to perform reading and merging of log blocks
- private final long totalTimeTakenToReadAndMergeBlocks;
+ private long totalTimeTakenToReadAndMergeBlocks;
// A timer for calculating elapsed time in millis
public final HoodieTimer timer = new HoodieTimer();
@SuppressWarnings("unchecked")
public HoodieMergedLogRecordScanner(FileSystem fs, String basePath,
List<String> logFilePaths, Schema readerSchema,
String latestInstantTime, Long maxMemorySizeInBytes, boolean
readBlocksLazily, boolean reverseReader,
int bufferSize, String spillableMapBasePath) {
+ this(fs, basePath, logFilePaths, readerSchema, latestInstantTime,
maxMemorySizeInBytes, readBlocksLazily,
+ reverseReader, bufferSize, spillableMapBasePath, true);
+ }
+
+ @SuppressWarnings("unchecked")
+ public HoodieMergedLogRecordScanner(FileSystem fs, String basePath,
List<String> logFilePaths, Schema readerSchema,
Review comment:
moving as comment under HUDI-1319
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
