nsivabalan commented on code in PR #12746:
URL: https://github.com/apache/hudi/pull/12746#discussion_r1936588234


##########
hudi-hadoop-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormatWriter.java:
##########
@@ -102,8 +102,11 @@ private FSDataOutputStream getOutputStream() throws 
IOException {
       boolean created = false;
       while (!created) {
         try {
+          if (storage.exists(logFile.getPath())) {

Review Comment:
   if we do not do this, we end up trying to create the same log file as 
previous version. and then hit FileAlreadyExistsException. and then we go ahead 
and create a new log file. 
   but by this time, two marker files are created, 1st one pointing to the 
previous committed log file. and the 2nd one referring to the log file created 
in the current inflight delta commit. 
   
   and during marker reconciliation, we end up deleting the 1st log file which 
is part of committed delta commit :( 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to