xushiyan commented on code in PR #283:
URL: https://github.com/apache/hudi-rs/pull/283#discussion_r1937624943
##########
.github/workflows/ci.yml:
##########
@@ -64,8 +64,7 @@ jobs:
- name: Cache dependencies
uses: Swatinem/rust-cache@v2
- name: Rust unit tests with coverage report
- #
https://github.com/xd009642/tarpaulin/issues/1092#issuecomment-1407739176
- run: cargo tarpaulin --engine llvm --no-dead-code --no-fail-fast
--all-features --workspace -o xml --output-dir ./cov-reports --skip-clean
+ run: make test-rust
Review Comment:
this disables code coverage generation using tarpaulin
##########
python/Makefile:
##########
@@ -34,12 +35,12 @@ setup: ## Setup the requirements
.PHONY: build
build: setup ## Build Python binding of hudi-rs
$(info --- Build Python binding ---)
- maturin build $(MATURIN_EXTRA_ARGS)
+ cd $(PYTHON_DIR) && maturin build $(MATURIN_EXTRA_ARGS)
Review Comment:
that's not a good experience as this moved the current dir to `python/` then
people need to cd back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
