wombatu-kun commented on code in PR #12695:
URL: https://github.com/apache/hudi/pull/12695#discussion_r1939042296
##########
hudi-cli/src/main/java/org/apache/hudi/cli/utils/HDFSParquetImporter.java:
##########
@@ -58,17 +54,14 @@
import java.time.ZoneId;
import java.time.format.DateTimeFormatter;
import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.Collections;
import java.util.List;
import scala.Tuple2;
/**
- * Loads data from Parquet Sources.
- *
- * @see HoodieStreamer
- * @deprecated This utility is deprecated in 0.10.0 and will be removed in
0.11.0. Use {@link HoodieStreamer.Config#runBootstrap} instead.
+ * Loads data from Parquet Sources. This class is moved to hudi-cli from
hudi-utilities.
+ * This feature, as separate utility, was deprecated in 0.10.0 and should be
removed in 0.11.0.
+ * Now it is used only by hudi-cli SparkMain IMPORT and UPSERT commands (for
compatibility support of hudi-cli API).
Review Comment:
No, we don't have test coverage for this class now. There were
TestHDFSParquetImporter (in hudi-utilities) and ITTestHDFSParquetImportCommand
(in hudi-cli) for it, which were disabled more than 3 years ago.
As we don't see any issues related to HDFSParquetImporter utility or
hudi-cli IMPORT/UPSERT-commands for last 3 years, there can be two reasons: 1)
HDFSParquetImporter still works well; 2) no one uses this functionality. In any
cases, this PR just cleans up unused/deprecated code and does'n break anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
