yihua commented on code in PR #12770:
URL: https://github.com/apache/hudi/pull/12770#discussion_r1942253244
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/KafkaOffsetGen.java:
##########
@@ -124,15 +124,26 @@ public static OffsetRange[]
computeOffsetRanges(Map<TopicPartition, Long> fromOf
Map<TopicPartition, Long>
toOffsetMap,
long numEvents,
long minPartitions) {
+ boolean needSplitToMinPartitions = minPartitions > toOffsetMap.size();
+ if (needSplitToMinPartitions && minPartitions % toOffsetMap.size() != 0)
{
Review Comment:
I think this validation is no longer needed as the number of target Kafka
partitions does not have to be multiples of the number of input partitions
anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
